From: Yoav Steinberg To: FFmpeg development discussions and patches Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] fixes in mpeg audio parsing Date: Wed, 12 Nov 2008 19:02:55 +0200 Sender: ffmpeg-devel-bounces@mplayerhq.hu User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) Hi, Attached are patches witch make some improvements for mp3 parsing. skip_vbrtag_and_id3v1.patch: - When file contains ID3v1 tag at the end don't attempt to read it as part of a packet. In some cases there are mp3 files where the ID3v1 tag was stuck forcefully at the end of the file inside the last frame boundary. In those cases the patch eliminates attempts to parse/decode the ID3 tag. - If we find a VBR tag at the beginning of the file don't attempt to parse it as a valid frame. parse_all_frames.patch: - Buffer packets when we loose sync and start counting "valid" frames until parser returns a valid frame. Then return buffered frames once we're back in sync. This prevents the parser from discarding valid frames in many cases. The goal of these patches was to improve the parsing of mp3 files so we only parse/decode the actual (and all of) the audio data. I also notice there's no CRC checks performed on mpeg audio frames with CRC info - this is a future to do:) Yoav.